[Openmp-commits] [PATCH] D82963: [OpenMP] Temporarily disable failing runtime and ompt tests for OpenMP 5.0

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jul 2 06:57:41 PDT 2020


Hahnfeld added inline comments.


================
Comment at: openmp/runtime/test/lit.cfg:110-119
+# Find exact version of clang, so that version specific XFAIL/UNSUPPORTED
+# can be used in tests
+if 'clang' in config.test_c_compiler:
+  cmd = subprocess.Popen([config.test_c_compiler, '-dumpversion'],
+                         stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+  out, err = cmd.communicate()
+  version_string = out.decode().split(".")
----------------
ABataev wrote:
> I thought we already have such processing for clang, no? Many tests are marked as UNSUPPORTED for some particular clang version already.
`openmp/cmake/OpenMPTesting.cmake` extracts the compiler version and the features are added via `config.test_compiler_features` above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82963/new/

https://reviews.llvm.org/D82963





More information about the Openmp-commits mailing list