[Openmp-commits] [PATCH] D82963: [OpenMP] Temporarily disable failing runtime and ompt tests for OpenMP 5.0

[Saiyedul Islam via Phabricator via Openmp-commits]

saiislam updated this revision to Diff 275063.
saiislam added a comment.

1. Added clang version identification in openmp/runtime/test
2. Marked these three tests as unsupported for clang-11
3. Refactored test lines to pass clang-format


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82963/new/

https://reviews.llvm.org/D82963

Files:
  openmp/runtime/test/env/kmp_set_dispatch_buf.c
  openmp/runtime/test/lit.cfg
  openmp/runtime/test/ompt/tasks/dependences.c
  openmp/runtime/test/worksharing/for/kmp_set_dispatch_buf.c


Index: openmp/runtime/test/worksharing/for/kmp_set_dispatch_buf.c
===================================================================
--- openmp/runtime/test/worksharing/for/kmp_set_dispatch_buf.c
+++ openmp/runtime/test/worksharing/for/kmp_set_dispatch_buf.c
@@ -3,6 +3,7 @@
 // RUN: %libomp-run 1 && %libomp-run 2 && %libomp-run 5
 // RUN: %libomp-compile -DMY_SCHEDULE=guided && %libomp-run 7
 // RUN: %libomp-run 1 && %libomp-run 2 && %libomp-run 5
+// UNSUPPORTED: clang-11
 #include <stdio.h>
 #include <omp.h>
 #include <stdlib.h>
Index: openmp/runtime/test/ompt/tasks/dependences.c
===================================================================
--- openmp/runtime/test/ompt/tasks/dependences.c
+++ openmp/runtime/test/ompt/tasks/dependences.c
@@ -1,6 +1,6 @@
 // RUN: %libomp-compile-and-run | %sort-threads | FileCheck %s
 // REQUIRES: ompt
-// UNSUPPORTED: gcc-4, gcc-5, gcc-6, gcc-7
+// UNSUPPORTED: gcc-4, gcc-5, gcc-6, gcc-7, clang-11
 
 #include "callback.h"
 #include <omp.h>
Index: openmp/runtime/test/lit.cfg
===================================================================
--- openmp/runtime/test/lit.cfg
+++ openmp/runtime/test/lit.cfg
@@ -107,11 +107,20 @@
 except NotImplementedError:
     pass
 
+# Find exact version of clang, so that version specific XFAIL/UNSUPPORTED
+# can be used in tests
+if 'clang' in config.test_c_compiler:
+  cmd = subprocess.Popen([config.test_c_compiler, '-dumpversion'],
+                         stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+  out, err = cmd.communicate()
+  version_string = out.decode().split(".")
+  if err == '' and len(version_string) > 0:
+    config.available_features.add("clang-" + version_string[0])
+
 # to run with icc INTEL_LICENSE_FILE must be set
 if 'INTEL_LICENSE_FILE' in os.environ:
     config.environment['INTEL_LICENSE_FILE'] = os.environ['INTEL_LICENSE_FILE']
 
-
 # substitutions
 config.substitutions.append(("%libomp-compile-and-run", \
     "%libomp-compile && %libomp-run"))
Index: openmp/runtime/test/env/kmp_set_dispatch_buf.c
===================================================================
--- openmp/runtime/test/env/kmp_set_dispatch_buf.c
+++ openmp/runtime/test/env/kmp_set_dispatch_buf.c
@@ -1,9 +1,15 @@
-// RUN: %libomp-compile && env KMP_DISP_NUM_BUFFERS=0 %libomp-run
-// RUN: env KMP_DISP_NUM_BUFFERS=1 %libomp-run && env KMP_DISP_NUM_BUFFERS=3 %libomp-run
-// RUN: env KMP_DISP_NUM_BUFFERS=4 %libomp-run && env KMP_DISP_NUM_BUFFERS=7 %libomp-run
-// RUN: %libomp-compile -DMY_SCHEDULE=guided && env KMP_DISP_NUM_BUFFERS=1 %libomp-run
-// RUN: env KMP_DISP_NUM_BUFFERS=3 %libomp-run && env KMP_DISP_NUM_BUFFERS=4 %libomp-run
+// RUN: %libomp-compile
+// RUN: env KMP_DISP_NUM_BUFFERS=0 %libomp-run
+// RUN: env KMP_DISP_NUM_BUFFERS=1 %libomp-run
+// RUN: env KMP_DISP_NUM_BUFFERS=3 %libomp-run
+// RUN: env KMP_DISP_NUM_BUFFERS=4 %libomp-run
 // RUN: env KMP_DISP_NUM_BUFFERS=7 %libomp-run
+// RUN: %libomp-compile -DMY_SCHEDULE=guided
+// RUN: env KMP_DISP_NUM_BUFFERS=1 %libomp-run
+// RUN: env KMP_DISP_NUM_BUFFERS=3 %libomp-run
+// RUN: env KMP_DISP_NUM_BUFFERS=4 %libomp-run
+// RUN: env KMP_DISP_NUM_BUFFERS=7 %libomp-run
+// UNSUPPORTED: clang-11
 #include <stdio.h>
 #include <omp.h>
 #include <stdlib.h>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82963.275063.patch
Type: text/x-patch
Size: 3239 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20200702/8b0227a5/attachment-0001.bin>