[Openmp-commits] [PATCH] D74925: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert created this revision.
jdoerfert added reviewers: lebedev.ri, JonChesterfield, fghanim, ABataev.
Herald added subscribers: guansong, bollu, hiraditya.
Herald added a project: LLVM.

If we deduplicate OpenMP runtime calls we have multiple `ident_t*` that
represent information like source location. So far, we simply kept the
one used by the replacement call. However, as exposed by PR44893, that
can cause problems if we have stack allocated `ident_t` objects. While
we need to revisit the use of these as well, it is clear that we
eventually want to merge source location information in some way. With
this patch we add the infrastructure to do so but without doing the
actual merge. Instead we pick a global `ident_t` from the replaced
calls, if possible, or create a new one with an unknown location
instead.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74925

Files:
  llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
  llvm/lib/Transforms/IPO/OpenMPOpt.cpp
  llvm/test/Transforms/OpenMP/gtid.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74925.245719.patch
Type: text/x-patch
Size: 9457 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20200220/202360cd/attachment.bin>