[Openmp-commits] [PATCH] D45890: [OMPT] Add implementation and tests of Archer tool

[Aaron Puchert via Phabricator via Openmp-commits]

aaronpuchert added inline comments.


================
Comment at: openmp/tools/archer/CMakeLists.txt:13-18
+add_library(archer SHARED ompt-tsan.cpp)
+add_library(archer_static STATIC ompt-tsan.cpp)
+
+install(TARGETS archer archer_static
+  LIBRARY DESTINATION ${OPENMP_INSTALL_LIBDIR}
+  ARCHIVE DESTINATION ${OPENMP_INSTALL_LIBDIR})
----------------
The commit message talks about setting `OMP_TOOL_LIBRARIES=libarcher.so`, so why do we build and install this as static library?

If there are uses for the static library, could we decide based on `LIBOMP_ENABLE_SHARED` or `BUILD_SHARED_LIBS` whether to build it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45890/new/

https://reviews.llvm.org/D45890