[Openmp-commits] [PATCH] D74145: [OpenMP][Offloading] Added support for multiple streams so that multiple kernels can be executed concurrently

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

I'll commit this one and D74258 <https://reviews.llvm.org/D74258> later.



================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:182
+  // Get the next stream on a given device in a round robin manner
+  CUstream &getNextStream(const int DeviceId) {
+    assert(DeviceId < static_cast<int>(NextStreamId.size()) &&
----------------
tianshilei1992 wrote:
> JonChesterfield wrote:
> > It looks like DeviceID should be unsigned here
> Well, yes, it should be. But if you take a look at what they're used, for example at line 725, you can see the declaration is `int32_t device_id`.
we make it an unsigned here. I can do that before I commit as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74145/new/

https://reviews.llvm.org/D74145