[Openmp-commits] [PATCH] D74258: [OpenMP] Switch default C++ standard to C++ 14

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

In D74258#1865532 <https://reviews.llvm.org/D74258#1865532>, @JonChesterfield wrote:

> > Unless there are good reasons to switch, I'd object because it requires newer versions of compilers than many HPC systems have.
>
> I disagree. The use case we would be supporting is:
>
> - building llvm libomptarget from source
> - using it with a binary llvm dist, or some other toolchain
> - won't download or build a newer toolchain


You can do all that if the runtime only requires a subset of its parent project.

> The advantage isn't in make_unique, it's in matching the rest of llvm which has required c++14 for months. It's not worth rehashing the stability-vs-progress discussion here when the parent project has already reached consensus.

I really hope that the OpenMP runtime has a broader usage than just with "the rest of llvm". It can be used standalone with Intel Compilers and GCC, and this is a great advantage for research.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74258/new/

https://reviews.llvm.org/D74258