[Openmp-commits] [PATCH] D74258: [OpenMP] Switch default C++ standard to C++ 14

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld requested changes to this revision.
Hahnfeld added a comment.
This revision now requires changes to proceed.

This should have a RFC on `openmp-dev`. As far as I understand the linked patch, the aim is to use `std::make_unique` which is just syntactic sugar IMO. Unless there are good reasons to switch, I'd object because it requires newer versions of compilers than many HPC systems have.



================
Comment at: openmp/cmake/HandleOpenMPOptions.cmake:32-34
+append_if(OPENMP_HAVE_STD_GNUPP11_FLAG "-std=gnu++14" CMAKE_CXX_FLAGS)
 if (NOT OPENMP_HAVE_STD_GNUPP11_FLAG)
+  append_if(OPENMP_HAVE_STD_CPP11_FLAG "-std=c++14" CMAKE_CXX_FLAGS)
----------------
You should rename this, otherwise an incremental build won't test the new flag IIRC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74258/new/

https://reviews.llvm.org/D74258