[Openmp-commits] [PATCH] D73077: [libomptarget] Implement wavefront functions for amdgcn

Matt Arsenault via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Feb 4 09:26:24 PST 2020


arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.hip:21
+
+// initialized with a 64-bit mask with bits set in positions less than the
+// thread's lane number in the warp
----------------
Capitalize comment


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.hip:30
+
+// initialized with a 64-bit mask with bits set in positions greater than the
+// thread's lane number in the warp
----------------
Capitalize comment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73077/new/

https://reviews.llvm.org/D73077





More information about the Openmp-commits mailing list