[Openmp-commits] [PATCH] D93723: [OpenMP] Add OpenMP Documentation for Libomptarget environment variables

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, with some nits to be addressed prior to landing.



================
Comment at: openmp/docs/design/Runtimes.rst:70
+
+``LIBOMPTARGET_INFO`` allows the user to request different types runtime
+information from ``libomptarget``. ``LIBOMPTARGET_INFO`` uses a 31-bit field to
----------------
types of?


================
Comment at: openmp/docs/design/Runtimes.rst:75
+application with debugging information enabled, this will enable filenames and
+variable declarations in the information messages. A full list of available
+flags is given below. 
----------------
Mention how to build the application with debug information. And that the runtime doesn't need to be a debug runtime.


================
Comment at: openmp/docs/design/Runtimes.rst:97
+
+   $ env LIBOMPTARGET_INFO=$((1 << 31 - 1)) ./your-application
+
----------------
As discussed offload, let's unreserve the bit and make -1 print everything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93723/new/

https://reviews.llvm.org/D93723