[Openmp-commits] [PATCH] D93727: [OpenMP] Add using bit flags to select Libomptarget Information

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

I like the direction. Granular debug printing is a good feature. As commented above, not convinced the -1 sentinel is worth the complexity.



================
Comment at: openmp/libomptarget/include/Debug.h:41
+/// 31-Bit field data attributes controlling information presented to the user.
+enum OpenMPInfoType : int32_t {
+  // Print data arguments and attributes upon entering an OpenMP device kernel.
----------------
Why not uint32, with zero for all flags clear as the default?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93727/new/

https://reviews.llvm.org/D93727