[Openmp-commits] [PATCH] D93429: [OpenMP] Add definitions for 5.1 interop to omp.h

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

Cool! I'm really happy to see this.

Given that we have a doxygen documentation for openmp now (not yet online but it can be build), we should start adding appropriate comments, especially to user facing functions. That should also give them information right in the IDE, which is arguably good.

That said, this file is used to create omp.h, right? If so, we should copy the description from the OpenMP standard here. Summary, maybe all of it.

---

FWIW, an early prototype can be found here https://github.com/jdoerfert/llvm-project/commit/c514fc3bfc22bee958f9aedde56dafee642bd381



================
Comment at: openmp/runtime/src/include/omp.h.var:169
+        omp_ipr_first = -9
+        /* 0..omp_get_num_interop_properties()-1 are reserved for implementation-defined properties */
+    } omp_interop_property_t;
----------------
Let's move it above the enum `/// ...`


================
Comment at: openmp/runtime/src/include/omp.h.var:172
+
+    #define omp_interop_none 0
+
----------------
Do we really want/need to define it or can we provide a constant variable, nicer for debugging I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93429/new/

https://reviews.llvm.org/D93429