[Openmp-commits] [PATCH] D64218: [OpenMP][NFCI] Cleanup the target synchronization implementation

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

In D64218#2455642 <https://reviews.llvm.org/D64218#2455642>, @JonChesterfield wrote:

> This looks like a difficult rebase. Some parts are obsolete (__kmpc_impl_active_thread_mask). Lifting runtime parameters with associated branches to compile time via the template is interesting but I wouldn't have guessed it's where we're losing most performance. Constant propagation probably does the same job with the bitcode RTL.

It was not about performance but code duplication. Back then, maybe now too, we have various copies of the barrier implementation which is, sub-optimal.

> I'd be inclined to abandon this patch and recreate it if desired

Agreed. But I might not be able to do that any time soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64218/new/

https://reviews.llvm.org/D64218