[Openmp-commits] [PATCH] D93055: [OpenMP] Add time profiling for libomptarget

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, I left two minor change requests below. Thanks for getting this up and running so quickly!



================
Comment at: openmp/libomptarget/src/CMakeLists.txt:41
+    target_compile_definitions(omptarget PUBLIC OMPTARGET_PROFILE)
+  endif()
+endif()
----------------
Move the conditional `if(OPENMP_ENABLE_LIBOMPTARGET_PROFILING)` to include all of the stuff, including the linking of things. So if it is disabled we build as we did before.



================
Comment at: openmp/libomptarget/src/rtl.cpp:37
+#if OMPTARGET_PROFILE_ENABLED
+static bool EnvProfilingEnabled = false;
+#endif
----------------
Make this a char* and set it to the value of `LIBOMPTARGET_PROFILE`. We will assume that is a path for the resulting file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93055/new/

https://reviews.llvm.org/D93055