[Openmp-commits] [PATCH] D93055: [OpenMP] Add time profiling for libomptarget

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Dec 10 13:58:55 PST 2020


jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/src/api.cpp:21
+#define TIMESCOPE
+#endif
 
----------------
jdoerfert wrote:
> Maybe we could move this in one of the header, private or rtl? We might even later use it for internal functions.
After looking at the output in a flamegraph, I'm not sure if we should not go with `__FUNCTION__` instead. Unclear if the types help in any way.

{F14666177}


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93055/new/

https://reviews.llvm.org/D93055



More information about the Openmp-commits mailing list