[Openmp-commits] [PATCH] D81054: [OpenMP] Introduce target memory manager

Joachim Protze via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Dec 10 13:50:21 PST 2020


protze.joachim added a comment.

I'm surprised to find no dlclose matching the dlopen. Instead of calling some function for init/destroy, can't we just use library constructor/destructors in the plugin? All MemoryManagers for a plugin should then be destroyed before the plugin is explicitly dlclosed.
I'm also surprised that LoadRTLs does not dlclose the library in case of missing symbols.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81054/new/

https://reviews.llvm.org/D81054



More information about the Openmp-commits mailing list