[Openmp-commits] [PATCH] D78566: [OpenMP] Add scaffolding for negative runtime tests

[Joel E. Denny via Phabricator via Openmp-commits]

jdenny added a comment.

In D78566#1995220 <https://reviews.llvm.org/D78566#1995220>, @Hahnfeld wrote:

> In D78566#1995119 <https://reviews.llvm.org/D78566#1995119>, @jdenny wrote:
>
> > I just noticed another issue: ompt tests are skipped if FileCheck is not available.  This is configured in `openmp/runtime/test/lit.cfg`.  However, other openmp test suites that use FileCheck don't bother.  Why is ompt different?
>
>
> Probably historic reasons, the OMPT tests were the first to use FileCheck.


Thanks.

> If other tests use it, we should probably make it required for all suites.

Maybe in another patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78566/new/

https://reviews.llvm.org/D78566