[Openmp-commits] [PATCH] D78566: [OpenMP] Add scaffolding for negative runtime tests

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Apr 21 09:42:04 PDT 2020


Hahnfeld added a comment.

> This patch makes not visible in all of the openmp project's test
>  suites. In all but libomptarget/test, it should be possible for a
>  test author to insert not before a use of the lit substitution for
>  running a test program.

I see no `config.substitutions` for the other test suites, so I guess it will try to use `not` from `PATH`? IIRC LLVM and Clang add a substitution from `not` to the full path (via `use_default_substitutions`, but that's probably not available for standalone builds). Doing so is a bit tricky because "not" may be part of the checked strings. LLVM does some funny `\| \bnot\b` regex (which I have yet to understand), so I leave it up to you if you want to dig into that. Alternatively, we can either provide `%not` (which makes it unambiguous) or just not wire it up for the other suites and adapt the commit message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78566/new/

https://reviews.llvm.org/D78566





More information about the Openmp-commits mailing list