[Openmp-commits] [PATCH] D77951: [OpenMP] Refined CUDA plugin to put all CUDA operations into class

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

I assume you tested this locally and it works as expected? If so, I think we can go ahead. One comment to address now below.



================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:247
+    return true;
+  }
+};
----------------
We check already in `resizeStreamPool`. Just return if it worked or not there. 


================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:870
+      return OFFLOAD_FAIL;
     }
 
----------------
You can make `checkResult` variadic in a separate commit to reuse it here. It could even be a macro if that makes it easier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77951/new/

https://reviews.llvm.org/D77951