[Openmp-commits] [PATCH] D77412: [OpenMP] Introduce stream pool to make sure the correctness of device synchronization

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Apr 9 20:40:46 PDT 2020


jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:250
+  // the best way not to refine the whole file.
+  friend int32_t __tgt_rtl_init_device(int32_t device_id);
+
----------------
No need to put your name here, `git blame` would know anyway.

We should move all the CUDA stuff into the stream manager and the stream manager out of the `RTLDeviceInfoTy` but both can be done later. For now just replace the `friends` with a getter.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77412/new/

https://reviews.llvm.org/D77412





More information about the Openmp-commits mailing list