[Openmp-commits] [PATCH] D76843: [Openmp] Libomptarget plugin for NEC SX-Aurora

[Manoel Roemmer via Phabricator via Openmp-commits]

manorom added inline comments.
Herald added a subscriber: yaxunl.


================
Comment at: openmp/libomptarget/plugins/ve/src/rtl.cpp:122
+    // Dynamically check how many devices we have
+    // For the moment we assume that VEO device IDs are consecutive
+    struct ve_nodeinfo node_info;
----------------
efocht wrote:
> simoll wrote:
> > Can we assume that?
> No. Devices can be missing or offline. For sizing the objects below this is ok, but not for selecting the ve nodeids.
Do we have to assume that VE node ids can be assigned completely at random?

We hoped that that would not be the case. Our rationale for  simply re-using the device ids we get passed  from libomptarget was, that the user would be able to set OMP_DEFAULT_DEVICE or the device() clause to a VE node id.

Now it seems to me that libomptarget expects openmp device ids to be consecutive, so if VE node ids are random or if we only report those which are present and online, we need to have a mapping between openmp device ids and VE node ids which should be somewhat predictable for a user.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76843/new/

https://reviews.llvm.org/D76843