[Openmp-commits] [PATCH] D77412: [OpenMP] Introduce stream pool to make sure the correctness of device synchronization

Fri Apr 3 16:49:15 PDT 2020

tianshilei1992 added a comment.

In D77412#1960259 <https://reviews.llvm.org/D77412#1960259>, @jdoerfert wrote:

> I like this a lot. I have one high-level question and a request for documentation:
>  Shouldn't we hide the stream stuff behind the `async_info` object instead?
>  I mean, we could avoid accidental misuse by restricting the getStream/returnStream to the constructor/destructor of async_info for example.
>  We should also unify the naming.
>
> Maybe, put the entire "stream" (=queue) management in a class. All the initialization happens there, all the tear down as well, and when you make it friends with `async_info` we can restrict access too.
>
> WDYT?

Agree. Will create a new class `StreamManager`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77412/new/

https://reviews.llvm.org/D77412