[Openmp-commits] [PATCH] D76755: Fix build on macOS sdk 10.12 and newer

Thu Apr 2 16:17:51 PDT 2020

yln added a comment.

In D76755#1941045 <https://reviews.llvm.org/D76755#1941045>, @fhahn wrote:

> Looks fine in general. Julian, any chance you could take a quick look at this?

For the sanitizers we are going the route of requiring a SDK that isn't super old.  Asking people/CI builders to upgrade to SDK 10.12 for **building** seems reasonable at this point (https://reviews.llvm.org/D74501).
Of course this doesn't solve the underlying issue of **running** on old systems (governed by the deployment target), but at least you can take advantage of the availability annotations in the SDK to do a proper runtime check.

In this particular case `pthread_mach_thread_np` seems to be a good general replacement (header says it's available since 10.4).  I recommend just using it unconditionally.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76755/new/

https://reviews.llvm.org/D76755