[Openmp-commits] [PATCH] D68100: [OpenMP 5.0] declare mapper runtime implementation

Fri Sep 27 12:00:07 PDT 2019

grokos added a comment.

In D68100#1686044 <https://reviews.llvm.org/D68100#1686044>, @ABataev wrote:

> In D68100#1685975 <https://reviews.llvm.org/D68100#1685975>, @lildmh wrote:
>
> > Please review when you have time, thanks
>
>
> Maybe, it is better to add a single function to pass the list of mappers to the runtime and use the old functions rather than just duplicate them? Something like `__tgt_mappers(...)` and store them in the runtime. Plus, modify the original functions to use mappers if they were provided. Thoughts?

I'm in favor of this solution, as it is less intrusive than the one posted in this patch. I think a revised patch will be quite smaller and the changes it introduces will be clearer.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68100/new/

https://reviews.llvm.org/D68100