[Openmp-commits] [PATCH] D67326: [OpenMP] FreeBSD address check if mapped more native

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.

This looks reasonable, but it would still be great to get input from @dim or @emaste.



================
Comment at: openmp/runtime/src/z_Linux_util.cpp:2030
+     return 0;
+  lstsz = lstsz * 4 / 3;
+  buf = reinterpret_cast<char *>(kmpc_malloc(lstsz));
----------------
Hahnfeld wrote:
> Hahnfeld wrote:
> > Can you add a comment explaining why this is necessary?
> Sorry, I still don't get why the code needs `lstsz * 4 / 3`, I'm not really familiar with the `sysctl` interface.
I'd still love to see an explanation for this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67326/new/

https://reviews.llvm.org/D67326