[Openmp-commits] [PATCH] D69652: [nfc][libomptarget] Reorganise support header

Thu Oct 31 04:49:33 PDT 2019

JonChesterfield added a comment.

Using EXTERN means dropping the __always_inline__ annotation on the functions. That was unintentional, changed back to INLINE in the implementation.

Also introduced DEVICE as an annotation for the non-inline header functions. We don't currently restrict the symbols exposed from the library and names like PadBytes are generic enough that I can imagine them colliding with application symbols. The mangled names are known to not collide, to the extent that no-one has reported such a collision.

================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/support.h:14
+#ifndef _OMPTARGET_SUPPORT_H_
+#define _OMPTARGET_SUPPORT_H_
+
----------------
jdoerfert wrote:
> The device RTL is not consistent here (__XXX and _XXX are used) and it is different from LLVM. I'd vote for LLVM style, thus `OMPTARGET_SUPPORT_H`
Yeah, I'd noticed the variation. I like your suggestion, will change it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69652/new/

https://reviews.llvm.org/D69652