[Openmp-commits] [PATCH] D69489: [libomptarget] Change nvcc compilation to use a unity build

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

Given that the build model I will advocate includes linking the device RTL into the application (as IR), I don't see missing incremental builds as a real drawback.

I think we should compile `unity.cu` also when we create a bitcode RTL. (This will simplify the cmake file, remove the need for llvm-link, ...)



================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:60
       src/task.cu
   )
 
----------------
Why is this still needed, or put differently, why do we not compile the unity.cu into bitcode where this variable (cuda_src_files) is still used below?


================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:62
 
   set(omp_data_objects src/omp_data.cu)
 
----------------
same as above (I think)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69489/new/

https://reviews.llvm.org/D69489