[Openmp-commits] [PATCH] D69476: [nfc][libomptarget] Warp size aware logging by using builtinvar abstraction consistently. Last part of D69423

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sun Oct 27 13:30:08 PDT 2019


JonChesterfield abandoned this revision.
JonChesterfield added a comment.

There's some collateral from this. Support.h is missing include guards and isn't safe to include multiple times. If guards are introduced, the inline functions that are defined in supporti.h generate warnings from Wundefined-inline. If supporti.h is appended to support, it turns out to be missing a number of headers.

I'm going detour to fix up some header dependencies then recreate an equivalent diff to this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69476/new/

https://reviews.llvm.org/D69476





More information about the Openmp-commits mailing list