[Openmp-commits] [PATCH] D69476: [nfc][libomptarget] Warp size aware logging by using builtinvar abstraction consistently. Last part of D69423

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

A subsequent patch will be proposed to move the six functions labelled 'Calls to the NVPTX layer' in support.h into target_impl.

That will allow me to delete the ugliest third of the api shim used by amdgcn to work around not having a cuda compiler. Code like:

  #define __CUDA_DEVICE_BUILTIN(FIELD, INTRINSIC)                                \
    __declspec(property(get = __fetch_builtin_##FIELD)) unsigned int FIELD;      \
    static inline __attribute__((always_inline))                                 \
        __attribute__((device)) unsigned int __fetch_builtin_##FIELD(void) {     \
      return INTRINSIC;                                                          \
    }
  //...
  __CUDA_DEVICE_BUILTIN(x, __nvvm_read_ptx_sreg_tid_x());


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69476/new/

https://reviews.llvm.org/D69476