[Openmp-commits] [PATCH] D69423: [NFC] [libomptarget] Move option.h into target_impl.h, name a magic number

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Oct 25 09:57:34 PDT 2019


JonChesterfield added a comment.

In D69423#1721433 <https://reviews.llvm.org/D69423#1721433>, @ABataev wrote:

> If everybody else is fine with the naming of the functions, the patch is good to go, I think.


Sticking with the local convention is probably less contentious, I think I'll swap it over. At some point we can run a find & replace across the rtl to change to the llvm style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69423/new/

https://reviews.llvm.org/D69423





More information about the Openmp-commits mailing list