[Openmp-commits] [PATCH] D69424: [NFC][libomptarget] move remaining device specific code out of omptarget-nvptx.h

Fri Oct 25 09:11:20 PDT 2019

JonChesterfield marked an inline comment as done.
JonChesterfield added inline comments.

================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h:16
+#include <cuda.h>
 #include <stdint.h>

----------------
ABataev wrote:
> JonChesterfield wrote:
> > ABataev wrote:
> > > Do we need `stdint.h` include here?
> > Sure. There's uint32_t and similar in this header, which could reasonably be the first or only one included in a translation unit.
> Then maybe include of `stdint.h` may be removed in `omptarget-nvptx.h`?
Removed. Thanks

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69424/new/

https://reviews.llvm.org/D69424