[Openmp-commits] [PATCH] D69424: [NFC][libomptarget] move remaining device specific code out of omptarget-nvptx.h

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h:16
+#include <cuda.h>
 #include <stdint.h>
 
----------------
JonChesterfield wrote:
> ABataev wrote:
> > Do we need `stdint.h` include here?
> Sure. There's uint32_t and similar in this header, which could reasonably be the first or only one included in a translation unit.
Then maybe include of `stdint.h` may be removed in `omptarget-nvptx.h`?


================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h:34-37
+/// Device environment data
+struct omptarget_device_environmentTy {
+  int32_t debug_level;
+};
----------------
JonChesterfield wrote:
> ABataev wrote:
> > Is this really target specific thing?
> This one is a driver/plugin specific thing. The hsa struct has another couple of fields.
Why do you have different fields for hsa? Maybe we can use the same fields for NVPTX if they are useful?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69424/new/

https://reviews.llvm.org/D69424