[Openmp-commits] [PATCH] D69220: [OpenMP] Enable OpenBSD support
Jonas Hahnfeld via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Sun Oct 20 03:46:12 PDT 2019
Hahnfeld added reviewers: jlpeyton, AndreyChurbanov.
Hahnfeld added a comment.
I think the patch is sufficiently uncontentious, only one formatting issue.
================
Comment at: openmp/runtime/src/z_Linux_util.cpp:2148-2159
+ while ((rc = sysctl(mib, 3, &kiv, &size, NULL, 0)) == 0) {
+ KMP_ASSERT(size);
+ if (kiv.kve_end == end)
+ break;
+
+ if (kiv.kve_start >= (uint64_t)addr &&
+ kiv.kve_end <= (uint64_t)addr) {
----------------
whitespace doesn't look right here which makes the patch hard to read. I think the logic makes sense, but please run this patch through `git-clang-format`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69220/new/
https://reviews.llvm.org/D69220
More information about the Openmp-commits
mailing list