[Openmp-commits] [PATCH] D68615: [libomptarget][nfc] Make interface.h target independent

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield marked 3 inline comments as done.
JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/include/interface.h:20
+#include <stdint.h>
+
+#ifdef __CUDACC__
----------------
`__CUDACC__` seems the preferred way of spelling this constraint. The amdgcn instantiation would add an equivalent few lines to this header and otherwise leave it unchanged:
```#ifdef __AMDGCN__
#define EXTERN extern "C" __attribute__((device))
typedef uint64_t __kmpc_impl_lanemask_t;
#endif```



================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:37
 endif()
 
+get_filename_component(devicertl_base_directory
----------------
Google suggests this is idiomatic cmake for 'find parent directory'


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68615/new/

https://reviews.llvm.org/D68615