[Openmp-commits] [PATCH] D62393: [OPENMP][NVPTX]Mark parallel level counter as volatile.

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

There was a lot of discussion here, largely about volatile vs atomic. The final patch looks uncontentious to me - accesses to parallelLevel are now wrapped in calls that implement atomic access in the appropriate fashion for nvptx. I agree that the test is at coarse granularity, but as it's essentially poking at the race condition I can't see a better way to do it.

I'm confident in this patch as it stands. @jdoerfert?


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62393/new/

https://reviews.llvm.org/D62393