[Openmp-commits] [PATCH] D68367: Initialise workFn to zero explicitly

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield created this revision.
JonChesterfield added reviewers: ABataev, jdoerfert, grokos.
Herald added a project: OpenMP.
Herald added a subscriber: openmp-commits.
JonChesterfield added a comment.

Tiny change ofc. I'm looking through the diff between in tree nvptx and out of tree amdgcn and this stuck out.


Initialise workFn to zero explicitly

It may be implicitly zero initialised by some toolchains.
This change would remove an out of tree patch for amdgcn.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68367

Files:
  openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.cu


Index: openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.cu
===================================================================
--- openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.cu
+++ openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.cu
@@ -76,6 +76,7 @@
       omptarget_nvptx_threadPrivateContext->GetTopLevelTaskDescr(threadId);
   nThreads = GetNumberOfWorkersInTeam();
   threadLimit = ThreadLimit;
+  omptarget_nvptx_workFn = 0;
 }
 
 EXTERN void __kmpc_kernel_deinit(int16_t IsOMPRuntimeInitialized) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68367.222947.patch
Type: text/x-patch
Size: 535 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20191003/0edc5357/attachment.bin>