[Openmp-commits] [PATCH] D70395: [OpenMP] Implementation of OMPT reduction callbacks

Fri Nov 29 10:06:09 PST 2019

jdoerfert added a comment.

In D70395#1764045 <https://reviews.llvm.org/D70395#1764045>, @protze.joachim wrote:

> Implement requested changes.
>
> @jdoerfert is this as you intended the change?

Yes. I was expecting functions but macros seems to be the solution used in this code so far. 
Do you think it is worth it to do it for `openmp/runtime/src/kmp_csupport.cpp` as well?

================
Comment at: openmp/runtime/test/ompt/callback.h:414
           break;
-        case ompt_sync_region_reduction:
+        default:
           break;
----------------
default again.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70395/new/

https://reviews.llvm.org/D70395