[Openmp-commits] [PATCH] D70395: [OpenMP] Implementation of OMPT reduction callbacks

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/runtime/src/kmp_barrier.cpp:140
+        }
+#endif
         (*reduce)(this_thr->th.th_local.reduce_data,
----------------
These seem to be basically the same block(s) of code multiple times. Can we outline them into a helper (including the guards)?


================
Comment at: openmp/runtime/test/ompt/callback.h:430
           break;
-        case ompt_sync_region_reduction:
+        default:
           break;
----------------
Can we not have default clauses so we get appropriate warnings?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70395/new/

https://reviews.llvm.org/D70395