[Openmp-commits] [PATCH] D68100: [OpenMP 5.0] declare mapper runtime implementation

Mon Nov 25 19:21:44 PST 2019

JonChesterfield added a comment.

In D68100#1759502 <https://reviews.llvm.org/D68100#1759502>, @lildmh wrote:

> Thanks for your reviews. Hope this looks better.

Thanks

> @JonChesterfield: If you insist, I can break this patch into 2 smaller ones. Since I don't have much time now, it will happen later.

Splitting large patches into NFC and functional change doesn't seem contentious but is not required.

The advantage is seen when the build breaks. It's less annoying for the author to have the functional change part temporarily reverted than to lose the whole lot, especially when the functional change is the smaller diff as I think it would be here.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68100/new/

https://reviews.llvm.org/D68100