[Openmp-commits] [PATCH] D45890: [OMPT] Add implementation and tests of Archer tool

[Taewook Oh via Phabricator via Openmp-commits]

twoh added inline comments.


================
Comment at: openmp/tools/archer/tests/lit.site.cfg.in:13
+config.operating_system = "@CMAKE_SYSTEM_NAME@"
+config.has_libatomic = @LIBOMP_HAVE_LIBATOMIC@
+
----------------
@protze.joachim Shouldn't this be `@LIBARCHER_HAVE_LIBATOMIC@` , based on openmp/tools/archer/tests/CMakeLists.txt? For our local unit test runs, they fail with 

```
llvm-lit: /home/engshare/third-party2/llvm/src/llvm/utils/lit/lit/TestingConfig.py:102: fatal: unable to parse config file '/home/engshare/third-party2/llvm/src/build-centos7-native/build/projects/openmp/tools/archer/tests/lit.site.cfg', traceback: Traceback (most recent call last):
  File "/home/engshare/third-party2/llvm/src/llvm/utils/lit/lit/TestingConfig.py", line 89, in load_from_path
    exec(compile(data, path, 'exec'), cfg_globals, None)
  File "/home/engshare/third-party2/llvm/src/build-centos7-native/build/projects/openmp/tools/archer/tests/lit.site.cfg", line 14
    config.has_libatomic =
                          ^
SyntaxError: invalid syntax
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45890/new/

https://reviews.llvm.org/D45890