[Openmp-commits] [PATCH] D69927: [OpenMP] Remove -Wl, -fini=__kmp_internal_end_fini

Mon Nov 18 14:02:38 PST 2019

aaronpuchert added a comment.

In D69927#1750132 <https://reviews.llvm.org/D69927#1750132>, @JonChesterfield wrote:

> The current change (without the racy test) looks good to me.

Yes, we don't seem to need an additional test case.

> This is presumably a user visible ABI break.

Can you explain what makes this is an ABI break? I don't think that applications linking with `libomp.so` need to be recompiled/relinked. The only thing that changed is that the dynamic linker won't run `__kmp_internal_end_fini` anymore. It wasn't exported anyway. Whether the library is compiled with `-fini` has (to my knowledge) no effect on executable files linked with the library.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69927/new/

https://reviews.llvm.org/D69927