[Openmp-commits] [PATCH] D70328: [libomptarget][nfc] Move some source into common from nvptx

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

One request but I'm fine with the workaround (includes) if they solve the problem



================
Comment at: openmp/libomptarget/deviceRTLs/common/debug.h:1
-//===------------- debug.h - NVPTX OpenMP debug macros ----------- CUDA -*-===//
+//===------------- debug.h - OpenMP debug macros --------------------------===//
 //
----------------
Please add the - C++ - annotation to header files


================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/cancel.cu:1
+#include "common/src/cancel.cpp"
----------------
This is not pretty but also not problematic. It's not like we have to maintain any more code, just a single file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70328/new/

https://reviews.llvm.org/D70328