[Openmp-commits] [PATCH] D69927: [libomptarget] Export __kmp_internal_end_fini to fix [Thin]LTO build

Wed Nov 13 19:24:11 PST 2019

aaronpuchert marked an inline comment as done.
aaronpuchert added a comment.

In D69927#1744369 <https://reviews.llvm.org/D69927#1744369>, @AndreyChurbanov wrote:

> foreign thread should crash if library closed w/o shutdown

Why exactly do we expect this crash?

> Not sure though how to properly run such test in LIT (all library tests so far used -fopenmp, while this one needs to avoid it).

Is the problem with `-fopenmp` that the library is unloaded too late for any meaningful side effects? Why is the destructor still necessary with `-fopenmp`? Maybe we can observe memory leaks with the address sanitizer otherwise?

Or maybe we could utilize the tracing? That would be a bit unconventional, and we would need to exclude Release builds, but it would be pretty reliable.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69927/new/

https://reviews.llvm.org/D69927