[Openmp-commits] [PATCH] D70186: [libomptarget][nfc] Use cuda variable wrappers from support.h

Wed Nov 13 09:32:30 PST 2019

jdoerfert added a comment.

In D70186#1744200 <https://reviews.llvm.org/D70186#1744200>, @ABataev wrote:

> In D70186#1744191 <https://reviews.llvm.org/D70186#1744191>, @JonChesterfield wrote:
>
> > Thanks. In general I agree re: NFC. At present I'm being cautious after the non-reproducible build errors of last week.
> >
> > The missing symbols were root caused - `__forceinline__` is not equal to always_inline - but duplicate symbols have me at a  loss, especially when the supporti.h => support.cu patch didn't show the issue. Hopefully Alexey will run into them again on one of the subdivided patches.
>
>
> Tested, works fine.

Thx!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70186/new/

https://reviews.llvm.org/D70186