[Openmp-commits] [PATCH] D70131: [libomptarget] Move supporti.h to support.cu

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

In D70131#1743199 <https://reviews.llvm.org/D70131#1743199>, @ABataev wrote:

> It does not break ghe build, I checked it.


That's a huge relief, thank you.

I've got the bitcode libraries building on my nvptx machine again which should decrease the frequency of such problems. For the curious, the cmake looks for llvm-link next to clang and gives up if it isn't there, which it wasn't on my machine. It might be worth making that cmake more verbose, at least printing out why it isn't building the bitcode library.

The performance justification here is a bit hand wavy. Inferring performance changes from bitcode change isn't ideal. I suspect that - in addition to targeted correctness tests for deviceRTL - we should probably have microbenchmarks doing things like invoking the reduction runtime call on various sizes of data.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70131/new/

https://reviews.llvm.org/D70131