[Openmp-commits] [PATCH] D70131: [libomptarget] Move supporti.h to support.cu

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

In D70131#1742637 <https://reviews.llvm.org/D70131#1742637>, @ABataev wrote:

> What about the performance with this version of the runtime?


The nvcc build will be slower as it doesn't support LTO. Fixable by changing to a unity build in a subsequent patch.

The bitcode library itself will be slightly less optimised as we combine the bitcode with llvm-link but don't run any subsequent optimisation passes on it. After the bitcode library is combined with the application, we'll have the same code as before. I don't think losing the always_inline attribute (which was implied by forceinline) makes any difference here as the functions are small.

We don't have any bitcode library level optimisations at present. I'd like to internalise the non-api symbols and run opt across it during the build. That's essentially a build time optimisation for the clients of the library and orthogonal to this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70131/new/

https://reviews.llvm.org/D70131