[Openmp-commits] [PATCH] D68100: [OpenMP 5.0] declare mapper runtime implementation

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added inline comments.


================
Comment at: libomptarget/src/exports:16-25
+    __tgt_target_data_begin_mapper;
+    __tgt_target_data_end_mapper;
+    __tgt_target_data_update_mapper;
+    __tgt_target_mapper;
+    __tgt_target_teams_mapper;
+    __tgt_target_data_begin_nowait_mapper;
+    __tgt_target_data_end_nowait_mapper;
----------------
On the last telecon, we decided to support this solution so adding new functions is accepted.


================
Comment at: libomptarget/src/interface.cpp:103
+  if (depNum + noAliasDepNum > 0)
+    __kmpc_omp_taskwait(NULL, 0);
+
----------------
`__kmpc_omp_taskwait(NULL, __kmpc_global_thread_num(NULL));`


================
Comment at: libomptarget/src/interface.cpp:171
+  if (depNum + noAliasDepNum > 0)
+    __kmpc_omp_taskwait(NULL, 0);
+
----------------
`__kmpc_omp_taskwait(NULL, __kmpc_global_thread_num(NULL));`


================
Comment at: libomptarget/src/interface.cpp:240
+  if (depNum + noAliasDepNum > 0)
+    __kmpc_omp_taskwait(NULL, 0);
+
----------------
`__kmpc_omp_taskwait(NULL, __kmpc_global_thread_num(NULL));`


================
Comment at: libomptarget/src/interface.cpp:293
+  if (depNum + noAliasDepNum > 0)
+    __kmpc_omp_taskwait(NULL, 0);
+
----------------
`__kmpc_omp_taskwait(NULL, __kmpc_global_thread_num(NULL));`


================
Comment at: libomptarget/src/interface.cpp:358
+  if (depNum + noAliasDepNum > 0)
+    __kmpc_omp_taskwait(NULL, 0);
+
----------------
`__kmpc_omp_taskwait(NULL, __kmpc_global_thread_num(NULL));`


================
Comment at: libomptarget/src/omptarget.cpp:361-364
+      if (Components.size() >= 0xffff) {
+        DP("The number of components exceed the limitation\n");
         return OFFLOAD_FAIL;
       }
----------------
Why we have this limitation?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68100/new/

https://reviews.llvm.org/D68100