[Openmp-commits] [PATCH] D69857: [libomptarget] Replace INLINE with DEVICE to work around nvcc deleting forceinline symbols

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

I think we should apply this patch anyway. It fixes the nvcc build which we have multiple reports of breakage from.

I can't see a reason why clang would conjure duplicate symbols, and have failed to reproduce anything like that, so am hopeful that it's a quirk of your current build setup.

Fundamentally I believe that nvcc would fail to handle inline functions correctly, as it fails to do a bunch of things correctly, and I believe that clang will build this correctly from a clean directory.

Otherwise, please provide enough details of your build setup that I can reproduce the failure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69857/new/

https://reviews.llvm.org/D69857