[Openmp-commits] [PATCH] D60884: [OpenMP][libomptarget] Enable usage of unified memory for declare target link variables

[Narayanaswamy, Ravi via Openmp-commits]

If you don't check when you load the symbol using dlsym but delay the check to when you actually try to use it.
If your plugin does not support it you cannot use it.
Ravi

-----Original Message-----
From: George Rokos via Phabricator [mailto:reviews at reviews.llvm.org] 
Sent: Friday, May 31, 2019 3:00 PM
To: gheorghe-teod.bercea at ibm.com; a.bataev at hotmail.com; caomhin at us.ibm.com; george_rokos at hotmail.com
Cc: hahnjo at hahnjo.de; zhang.guansong at gmail.com; jdoerfert at anl.gov; openmp-commits at lists.llvm.org; ron.lieberman at amd.com; jatin.bhateja at gmail.com; lildmh at gmail.com; Gregory.Rodgers at amd.com; acjacob at us.ibm.com; Narayanaswamy, Ravi <ravi.narayanaswamy at intel.com>; jlebar at google.com; tra at google.com
Subject: [PATCH] D60884: [OpenMP][libomptarget] Enable usage of unified memory for declare target link variables

grokos added inline comments.


================
Comment at: libomptarget/plugins/exports:5
     __tgt_rtl_number_of_devices;
+    __tgt_rtl_init_requires;
     __tgt_rtl_init_device;
----------------
One last question because I'm not very familiar with exporting symbols. If a plugin does not implement `__tgt_rtl_init_requires` (as is the case with generic-elf-64), will there be any problem with exporting the symbol?


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60884/new/

https://reviews.llvm.org/D60884