[Openmp-commits] [PATCH] D60884: [OpenMP][libomptarget] Enable usage of unified memory for declare target link variables

[Gheorghe-Teodor Bercea via Phabricator via Openmp-commits]

gtbercea marked an inline comment as done.
gtbercea added inline comments.


================
Comment at: libomptarget/plugins/cuda/src/rtl.cpp:276
+  DeviceInfo.RequiresFlags = RequiresFlags;
+  return RequiresFlags;
+}
----------------
grokos wrote:
> Hahnfeld wrote:
> > This will truncate `int64_t RequiresFlags` to `int32_t`. Does it make sense to change the return type to `int64_t`?
> I would suggest that we change the return type to 64 bits. In the future we may need to add extra "requires" attributes that go beyond 32 bits and then we will have to modify this interface function. Let's be proactive and avoid such situations. The same thing happened before with map types and device IDs.
Agreed. Just updated the patch to reflect that.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60884/new/

https://reviews.llvm.org/D60884