[Openmp-commits] [PATCH] D62034: compiler-rt/lib/builtins: s/#include <windows.h>/#include <Windows.h>/g to match proper case.

Puyan Lotfi via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri May 17 11:17:30 PDT 2019

plotfi added a comment.
Herald added a subscriber: dexonsmith.

In D62034#1506102 <https://reviews.llvm.org/D62034#1506102>, @mstorsjo wrote:

> Yes, MinGW headers are all lowercase.
> And the Windows SDK, where the file is spelled with a capital W, isn't self-consistent (some headers include others with a different capitalization than the files actually are stored with), so to use the official Windows SDK on a case sensitive file system, you need some sort of case fixup anyway. (Or did that change very recently?) And in that case, making it all lowercase is the simplest, which also happens to match the MinGW headers.

We can't control the case mismatches in the Windows SDK but we can control them in LLVM. Why should we consistently use the wrong case? The difference between LLVM and the Windows SDK using the wrong case is, that we can maintain a vfs overlay file for the Windows SDK only and be fairly certain that it wont change that frequently.

  rG LLVM Github Monorepo



More information about the Openmp-commits mailing list